Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codecov as github action, set permissions to read content only #1530

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

k4leung4
Copy link
Contributor

@k4leung4 k4leung4 commented Mar 1, 2022

Signed-off-by: Kenny Leung kleung@chainguard.dev

Summary

This adds codecov as the code coverage tool for PRs.
Similar to what is being done in rekor in sigstore/rekor#676

Add OS was env to differentiate between different matrix runs.

Ticket Link

Fixes

Release Note

NONE

@@ -55,7 +57,9 @@ jobs:
with:
go-version: ${{ env.GO_VERSION }}
- name: Run Go tests
run: go test ./...
run: go test -v coverprofile=coverage.txt -covermode=atomic ./...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like you're missing the - in front of coverprofile=coveragee.txt

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@3a81b51). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1530   +/-   ##
=======================================
  Coverage        ?   26.44%           
=======================================
  Files           ?      126           
  Lines           ?     7214           
  Branches        ?        0           
=======================================
  Hits            ?     1908           
  Misses          ?     5095           
  Partials        ?      211           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a81b51...183cee0. Read the comment docs.

@k4leung4 k4leung4 force-pushed the codecov branch 2 times, most recently from faf5dc5 to cbeb3c5 Compare March 1, 2022 23:00
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
@dlorenc dlorenc merged commit 0b3c68d into sigstore:main Mar 2, 2022
@github-actions github-actions bot added this to the v1.6.0 milestone Mar 2, 2022
@k4leung4 k4leung4 deleted the codecov branch March 8, 2022 23:12
mlieberman85 pushed a commit to mlieberman85/cosign that referenced this pull request May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants