Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the transparency log feature out of experimental #116

Closed
dlorenc opened this issue Mar 20, 2021 · 7 comments
Closed

Move the transparency log feature out of experimental #116

dlorenc opened this issue Mar 20, 2021 · 7 comments
Assignees

Comments

@dlorenc
Copy link
Member

dlorenc commented Mar 20, 2021

No description provided.

@dlorenc
Copy link
Member Author

dlorenc commented Mar 27, 2021

Some things I want to figure out first:

How should this be configured? Opt in vs. opt out?

Proposal: Upload send by default for public images (where we can tell), but opt-in for private images.

How should verification be configured?

Is it a failure to verify if the signature is not present?
Should we check by default?

Proposal: Check by default for a public image., but warn if the signature is not present, but still pass. Opt-in check for private images. If the opt-in flag is passed for public or private, fail if the signature is not present.

@dlorenc
Copy link
Member Author

dlorenc commented May 1, 2021

I think we're close here with offline bundling. We'll still want to be careful about adding entries to the log, but verification can happen if there's a bundle, whether or not we're in experimental.

@trixor
Copy link
Member

trixor commented Aug 2, 2022

@dlorenc is this issue still valid or should we close it out? It was added to the GA plan (unclear as to why), so I wanted to verify before taking it off the plan of record.

@priyawadhwa
Copy link
Contributor

So this basically means that we will remove the "experimental" env var requirement from cosign once Rekor/Fulcio are stable. Think it makes sense as a GA requirement since GA assumes the services are reliable not experimental.

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@znewman01
Copy link
Contributor

I feel like this is covered between #2387 and #2376 🤷

@priyawadhwa
Copy link
Contributor

sgtm, will close!

tommyd450 added a commit to tommyd450/cosign that referenced this issue Jan 17, 2024
…at-v2.2

Update RHTAP references (redhat-v2.2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants