Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aggregate attestation v2 response #6926

Merged

Conversation

eserilev
Copy link
Collaborator

@eserilev eserilev commented Feb 6, 2025

Closes #6925

Ensure that we return a fork versioned response in the v2 case, plus a small refactor

@eserilev eserilev added HTTP-API electra Required for the Electra/Prague fork v7.0.0-beta.0 New release c. Q1 2025 ready-for-review The code is ready for review labels Feb 6, 2025
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

michaelsproul added a commit that referenced this pull request Feb 7, 2025
Squashed commit of the following:

commit c11c343
Author: Eitan Seri-Levi <eserilev@ucsc.edu>
Date:   Thu Feb 6 17:32:34 2025 +0200

    fix test

commit 4203b56
Author: Eitan Seri-Levi <eserilev@ucsc.edu>
Date:   Thu Feb 6 16:38:13 2025 +0200

    add consensus version header

commit 37c9b67
Author: Eitan Seri-Levi <eserilev@ucsc.edu>
Date:   Thu Feb 6 14:39:11 2025 +0200

    Return fork versioned response and a small refactor
@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Feb 9, 2025
mergify bot added a commit that referenced this pull request Feb 9, 2025
@mergify mergify bot merged commit 6032f15 into sigp:unstable Feb 9, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
electra Required for the Electra/Prague fork HTTP-API ready-for-merge This PR is ready to merge. v7.0.0-beta.0 New release c. Q1 2025
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants