-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aggregate attestation v2 response #6926
Merged
mergify
merged 4 commits into
sigp:unstable
from
eserilev:fix-aggregate-attestation-v2-response
Feb 9, 2025
Merged
Fix aggregate attestation v2 response #6926
mergify
merged 4 commits into
sigp:unstable
from
eserilev:fix-aggregate-attestation-v2-response
Feb 9, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
michaelsproul
added a commit
that referenced
this pull request
Feb 7, 2025
Squashed commit of the following: commit c11c343 Author: Eitan Seri-Levi <eserilev@ucsc.edu> Date: Thu Feb 6 17:32:34 2025 +0200 fix test commit 4203b56 Author: Eitan Seri-Levi <eserilev@ucsc.edu> Date: Thu Feb 6 16:38:13 2025 +0200 add consensus version header commit 37c9b67 Author: Eitan Seri-Levi <eserilev@ucsc.edu> Date: Thu Feb 6 14:39:11 2025 +0200 Return fork versioned response and a small refactor
KaloyanTanev
approved these changes
Feb 7, 2025
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
electra
Required for the Electra/Prague fork
HTTP-API
ready-for-merge
This PR is ready to merge.
v7.0.0-beta.0
New release c. Q1 2025
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6925
Ensure that we return a fork versioned response in the v2 case, plus a small refactor