Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use data column batch verification consistently #6851

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Use data column batch verification consistently #6851

merged 2 commits into from
Feb 3, 2025

Conversation

dapplion
Copy link
Collaborator

@dapplion dapplion commented Jan 23, 2025 •
edited
Loading

Issue Addressed

Resolve a TODO(das) to use KZG batch verification in put_rpc_custody_columns

Proposed Changes

Uses verify_kzg_for_data_column_list_with_scoring in all paths that send more than one column. To use batch verification and have attributability of which peer is sending a bad column.

Needs to move verify_kzg_for_data_column_list_with_scoring into the type's module to convert to the KZG verified type.

@dapplion dapplion added ready-for-review The code is ready for review das Data Availability Sampling labels Jan 23, 2025
@dapplion dapplion mentioned this pull request Jan 25, 2025
Open
52 tasks
@jimmygchen jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jan 30, 2025
@dapplion dapplion requested a review from jxs as a code owner February 1, 2025 05:03
@dapplion dapplion added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Feb 1, 2025
jimmygchen
jimmygchen approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Feb 3, 2025
mergify bot added a commit that referenced this pull request Feb 3, 2025
@mergify
Merge of #6851
f5bb888
@mergify mergify bot mentioned this pull request Feb 3, 2025
Closed
14 tasks
@mergify mergify bot merged commit 95cec45 into sigp:unstable Feb 3, 2025
31 checks passed
@jimmygchen jimmygchen mentioned this pull request Feb 3, 2025
Open
@dapplion dapplion deleted the kzg-batch-peerdas branch February 3, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmygchen jimmygchen jimmygchen approved these changes

@jxs jxs Awaiting requested review from jxs jxs is a code owner

Assignees
No one assigned
Labels
das Data Availability Sampling ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dapplion @jimmygchen