Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not send column requests if there is no blob for the block. #6814

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Do not send column requests if there is no blob for the block. #6814

merged 3 commits into from
Jan 20, 2025

Conversation

jimmygchen
Copy link
Member

Issue Addressed

We currently send custody column requests to peers even on blocks that do not contain any blobs. This is unnecessary and is removed in this PR.

@jimmygchen jimmygchen added bug Something isn't working ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! das Data Availability Sampling labels Jan 17, 2025
@jimmygchen jimmygchen requested a review from dapplion January 17, 2025 05:15
@jimmygchen jimmygchen requested a review from jxs as a code owner January 17, 2025 05:15
@jimmygchen jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. ready-for-review The code is ready for review and removed ready-for-review The code is ready for review waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jan 17, 2025
jimmygchen added a commit to jimmygchen/lighthouse that referenced this pull request Jan 17, 2025
@jimmygchen
Do not send column requests if there is no blob for the block (sigp#6814
585e21f 
)

Squashed commit of the following:

commit 884ba44
Author: Jimmy Chen <jchen.tc@gmail.com>
Date:   Fri Jan 17 16:13:28 2025 +1100

    Do not send column requests if there is no blob for the block.
@jimmygchen jimmygchen requested a review from dapplion January 20, 2025 05:36
@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. ready-for-review The code is ready for review and removed ready-for-review The code is ready for review ready-for-merge This PR is ready to merge. labels Jan 20, 2025
@jimmygchen jimmygchen mentioned this pull request Jan 20, 2025
Merged
@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. waiting-on-author The reviewer has suggested changes and awaits thier implementation. ready-for-review The code is ready for review and removed ready-for-review The code is ready for review ready-for-merge This PR is ready to merge. waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jan 20, 2025
@jimmygchen jimmygchen requested a review from dapplion January 20, 2025 06:53
@jimmygchen
Copy link
Member Author

Just found that the previous solution didn't actually work because we don't pass the blob count to CustodyRequestState.

I realise the we actually have ComponentRequests::NotNeeded but it was never set correctly and I think this is a better fix: aad2a8e

@jimmygchen jimmygchen force-pushed the do-not-send-custody-request-no-blobs branch from aad2a8e to 085197d Compare January 20, 2025 06:56
dapplion
dapplion approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! Better solution

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jan 20, 2025
@jimmygchen
Copy link
Member Author

@mergify queue

@mergify Mergify
Copy link

mergify bot commented Jan 20, 2025 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 6ce33c4

@mergify mergify bot merged commit 6ce33c4 into sigp:unstable Jan 20, 2025
30 checks passed
@jimmygchen jimmygchen deleted the do-not-send-custody-request-no-blobs branch January 20, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion approved these changes

@jxs jxs Awaiting requested review from jxs jxs is a code owner

Assignees
No one assigned
Labels
bug Something isn't working das Data Availability Sampling low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmygchen @dapplion