Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete OTB verification service #6631

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Conversation

michaelsproul
Copy link
Member

Proposed Changes

One step closer to deleting all the old "merge" code, this PR removes the optimistic transition block verifier. It served us well, but is no longer required!

@michaelsproul michaelsproul added ready-for-review The code is ready for review code-quality v7.0.0-beta.0 New release c. Q1 2025 labels Nov 29, 2024
Copy link
Collaborator

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with the code, but looks like a simple deletion

@michaelsproul
Copy link
Member Author

@mergify queue

Copy link

mergify bot commented Dec 18, 2024

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Dec 18, 2024
Copy link

mergify bot commented Dec 18, 2024

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Dec 19, 2024
@michaelsproul
Copy link
Member Author

@mergify requeue

Copy link

mergify bot commented Dec 19, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Dec 19, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 07e82da

mergify bot added a commit that referenced this pull request Dec 19, 2024
@mergify mergify bot merged commit 07e82da into sigp:unstable Dec 19, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality ready-for-merge This PR is ready to merge. v7.0.0-beta.0 New release c. Q1 2025
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants