Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap finalized chains based on processed batches #6203

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

AgeManning
Copy link
Member

Issue Addressed

Previously we decided whether to swap finalized chains based on validated patches. It is a more robust approach to make this decision based on processed batches.

This PR shifts the switch to use processed batches rather than validated.

@AgeManning AgeManning added the ready-for-review The code is ready for review label Jul 30, 2024
@AgeManning AgeManning requested a review from jimmygchen July 30, 2024 05:15
@jimmygchen jimmygchen added the v5.3.0 Q3 2024 release with database changes! label Jul 30, 2024
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple fix, looks good!

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jul 30, 2024
@michaelsproul
Copy link
Member

@mergify queue

Copy link

mergify bot commented Jul 30, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 75e9348

@mergify mergify bot merged commit 75e9348 into sigp:release-v5.3.0 Jul 30, 2024
28 checks passed
@dapplion
Copy link
Collaborator

👍 Fix makes sense!

AgeManning added a commit to AgeManning/lighthouse that referenced this pull request Sep 3, 2024
chong-he pushed a commit to chong-he/lighthouse that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge. v5.3.0 Q3 2024 release with database changes!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants