Remove some easy Electra TODOs #5928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
ready-for-review
michaelsproul
force-pushed
the
remove-electra-todos
branch
from
84543fb to
1dde8df
Compare
dapplion
approved these changes
Jun 17, 2024
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 1eb8694 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Remove 3 TODOs related to Electra:
bellatrix_readiness.rswhich does genesis block checks).PartialBeaconState. This is going away soon with tree-states anyway.ExecutionPayloadHeader::ssz_max_var_len_for_fork. The extra data is still the only variable-length field inExecutionPayloadHeader, so this function is still correct. If the spec changes, the light client tests should catch any discrepancy here too.