remove exit-future #5183
Merged
remove exit-future #5183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxs
force-pushed
the
remove-exit-future
branch
2 times, most recently
from
1687d97 to
6e4d3d3
Compare
as it is non maintained, and replace with async-channel which is already in the repo.
jxs
force-pushed
the
remove-exit-future
branch
from
6e4d3d3 to
b29f6e5
Compare
AgeManning
approved these changes
Feb 8, 2024
|
The tests need to be fixed. Seems the update has removed a field. |
AgeManning
requested changes
Feb 8, 2024
AgeManning
added
the
waiting-on-author
…move-exit-future
jxs
force-pushed
the
remove-exit-future
branch
from
8720a6c to
4be6084
Compare
jxs
added
ready-for-review
AgeManning
approved these changes
Feb 27, 2024
|
@Mergifyio queue |
🛑 The pull request has been removed from the queue
|
5 tasks
…move-exit-future
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 65c4ff0 |
pawanjay176
pushed a commit
to pawanjay176/lighthouse
that referenced
this pull request
Mar 5, 2024
* remove exit-future usage, as it is non maintained, and replace with async-channel which is already in the repo. * Merge branch 'unstable' of https://github.com/sigp/lighthouse into remove-exit-future * Merge branch 'unstable' of https://github.com/sigp/lighthouse into remove-exit-future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
the last release was 4 years ago and its repo has been archived. We already have
async-channelin the repo, so use it instead