You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR addresses the issue where attestations failing with UnknownHeadBlock are incorrectly processed through the slasher, leading to subsequent failures in signature verification (SignatureNotChecked) The subsequent failure occurs when attempting to load the state for the target block. This is expected when the target is identical to the head, leading to an unknown state. The proposed solution involves requeuing attestations without involving the slasher when encountering UnknownHeadBlock.
Some UnknownTargetRoot errors could still occur particularly during startup. It happens when the beacon_block_root slot is later than target_root slot. However they are harmless because the requeueing will usually take care of processing them later.
🛑 The pull request has been removed from the queue default
The queue conditions cannot be satisfied due to failing checks.
You can take a look at Queue: Embarked in merge queue check runs for more details.
In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment @mergifyio refresh on the pull request.
🛑 The pull request has been removed from the queue default
The queue conditions cannot be satisfied due to failing checks.
You can take a look at Queue: Embarked in merge queue check runs for more details.
In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment @mergifyio refresh on the pull request.
Squashed commit of the following:
commit 7adfecc
Author: armaganyildirak <armaganyildirak@gmail.com>
Date: Wed Dec 13 15:22:02 2023 -0500
Fix the UnknownTargetRoot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
michaelsproul
added
work-in-progress
Issue Addressed
#4972
Proposed Changes
This PR addresses the issue where attestations failing with
UnknownHeadBlockare incorrectly processed through the slasher, leading to subsequent failures in signature verification (SignatureNotChecked) The subsequent failure occurs when attempting to load the state for the target block. This is expected when the target is identical to the head, leading to an unknown state. The proposed solution involves requeuing attestations without involving the slasher when encounteringUnknownHeadBlock.Some
UnknownTargetRooterrors could still occur particularly during startup. It happens when thebeacon_block_rootslot is later thantarget_rootslot. However they are harmless because the requeueing will usually take care of processing them later.Additional Info