-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BlindedBlobsBundle
SSZ list max length and update builder tests
#4710
Update BlindedBlobsBundle
SSZ list max length and update builder tests
#4710
Conversation
320cb67
to
d3c38a8
Compare
BlindedBlobsBundle
SSZ list max length and update builder tests
e6ce74f
to
d5de9fb
Compare
d5de9fb
to
0192a8e
Compare
I haven't got mock builder fully working with mock relay yet, but I think these changes are good to go. I think we need a modified |
afc83f7
to
64cf0bf
Compare
I think our local testing with Tested using this version of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! looks good to me
Co-authored-by: realbigsean <seananderson33@GMAIL.com>
Issue Addressed
Addresses #4665
Proposed Changes
MAX_BLOB_COMMITMENTS_PER_BLOCK
as max length forBlindedBlobsBundle
SSZ lists. This removes theBuilderKzgCommitments
type and replace its usage withBlockBodyKzgCommitments
everywhere, and renamingBlockBodyKzgCommitments
back to justKzgCommitments
. Builder spec PR:MAX_BLOB_COMMITMENTS_PER_BLOCK
as max length for BlindedBlobsBundle SSZ lists ethereum/builder-specs#87mev-rs
andethereum-consensus
dependencies to support latest deneb spec.mock_builder::open_bid
to convert response tomev-rs
ExecutionPayload
type correctlyIssues
There's an issue with proposer prep that's currently being fixed in #4703, and the fix is required before continuing with testing.