Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BlindedBlobsBundle SSZ list max length and update builder tests #4710

Merged
merged 10 commits into from
Sep 9, 2023

Conversation

jimmygchen
Copy link
Member

@jimmygchen jimmygchen commented Sep 7, 2023

Issue Addressed

Addresses #4665

Proposed Changes

  • Use MAX_BLOB_COMMITMENTS_PER_BLOCK as max length for BlindedBlobsBundle SSZ lists. This removes the BuilderKzgCommitments type and replace its usage with BlockBodyKzgCommitments everywhere, and renaming BlockBodyKzgCommitments back to just KzgCommitments. Builder spec PR:
  • Testing:
    • Update mev-rs and ethereum-consensus dependencies to support latest deneb spec.
    • Update mock_builder::open_bid to convert response to mev-rs ExecutionPayload type correctly
    • Update local testnet scripts and README to support builder testing.

Issues

There's an issue with proposer prep that's currently being fixed in #4703, and the fix is required before continuing with testing.

@jimmygchen jimmygchen self-assigned this Sep 7, 2023
@jimmygchen jimmygchen changed the title Deneb builder testing: MockBuilder updates Deneb builder flow updates Sep 7, 2023
@jimmygchen jimmygchen force-pushed the deneb-builder-testing branch 2 times, most recently from 320cb67 to d3c38a8 Compare September 7, 2023 02:13
@jimmygchen jimmygchen changed the title Deneb builder flow updates Update BlindedBlobsBundle SSZ list max length and update builder tests Sep 7, 2023
@jimmygchen jimmygchen force-pushed the deneb-builder-testing branch 2 times, most recently from e6ce74f to d5de9fb Compare September 7, 2023 05:44
@jimmygchen jimmygchen force-pushed the deneb-builder-testing branch from d5de9fb to 0192a8e Compare September 7, 2023 05:46
@jimmygchen jimmygchen added the ready-for-review The code is ready for review label Sep 7, 2023
@jimmygchen
Copy link
Member Author

I haven't got mock builder fully working with mock relay yet, but I think these changes are good to go.

I think we need a modified mock_builder to make it work with mock-relay unfortunately. The payload header modifications in mock builder invalidates the block hash, which likely means the block hash needs to be recomputed and cached separately within the mock builder.

@jimmygchen jimmygchen force-pushed the deneb-builder-testing branch from afc83f7 to 64cf0bf Compare September 8, 2023 04:52
@jimmygchen
Copy link
Member Author

I think our local testing with mock-relay is good enough now (able to cover fetch bid, reveal payload and construct a full block and publish), and happy to continue testing when we have mev infra in devnets. Unfortunately it's a bit tricky to build valid payload using mock/noop builder, and probably not going to help us much even if we get it to work.

Tested using this version of mock-relay: realbigsean/mock-relay#7

Copy link
Member

@realbigsean realbigsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! looks good to me

scripts/local_testnet/README.md Outdated Show resolved Hide resolved
Co-authored-by: realbigsean <seananderson33@GMAIL.com>
@jimmygchen jimmygchen merged commit 1db7394 into sigp:deneb-free-blobs Sep 9, 2023
@jimmygchen jimmygchen deleted the deneb-builder-testing branch September 9, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deneb ready-for-review The code is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants