Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kintsugi Diva comments #2836

Merged
merged 2 commits into from
Nov 30, 2021
Merged

Conversation

paulhauner
Copy link
Member

Issue Addressed

NA

Proposed Changes

Addresses comments raised by @divagant-martian during this review of #2768.

Additional Info

NA

@paulhauner paulhauner added ready-for-review The code is ready for review kintsugi 🍵 labels Nov 30, 2021
@paulhauner paulhauner mentioned this pull request Nov 30, 2021
@paulhauner paulhauner changed the title Kintsugi diva comments Kintsugi Diva comments Nov 30, 2021
Copy link
Collaborator

@divagant-martian divagant-martian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@paulhauner paulhauner merged commit 2b92602 into sigp:kintsugi Nov 30, 2021
@paulhauner paulhauner deleted the kintsugi-diva-comments branch November 30, 2021 02:34
paulhauner added a commit that referenced this pull request Dec 2, 2021
* Remove TODOs

* Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kintsugi 🍵 ready-for-review The code is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants