Accept --terminal-total-difficuty-override as decimal
#2676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulhauner
added
ready-for-review
zedt3ster
approved these changes
Oct 5, 2021
|
Please do not merge for now. |
@zedt3ster asked to delay merging this since it's a breaking change and would have been really annoying during the F2F. The F2F is over now, and I'm keen to get this merged before we get an influx of new users. It'll only get harder to change from this point. I've run this past Proto, who is involved in spinning up the new testnets. He has given me the green light. All of this considered, I'm going to merge this now. |
paulhauner
added a commit
that referenced
this pull request
Oct 12, 2021
paulhauner
added a commit
that referenced
this pull request
Oct 27, 2021
paulhauner
added a commit
to paulhauner/lighthouse
that referenced
this pull request
Nov 3, 2021
paulhauner
added a commit
that referenced
this pull request
Nov 11, 2021
paulhauner
added a commit
that referenced
this pull request
Nov 28, 2021
paulhauner
added a commit
that referenced
this pull request
Nov 28, 2021
paulhauner
added a commit
that referenced
this pull request
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
NA
Proposed Changes
As per the presently un-approved ethereum/consensus-specs#2645, parse
--terminal-total-difficuty-overrideas a decimal integer instead of 0x-prefixed hex.Although we don't have clear guidance on this from the spec, I understand that this is the most convenient format for the merge event.
Additional Info
NA