Comment out header gas limit mutation.

sigp · Sep 7, 2023 · 99d2137 · 99d2137
1 parent 8371772
commit 99d2137
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/beacon_node/beacon_chain/src/beacon_chain.rs b/beacon_node/beacon_chain/src/beacon_chain.rs
@@ -5010,7 +5010,7 @@ impl<T: BeaconChainTypes> BeaconChain<T> {
                         .ok_or(BlockProductionError::TrustedSetupNotInitialized)?;
                     kzg_utils::validate_blobs::<T::EthSpec>(
                         kzg,
-                        &expected_kzg_commitments,
+                        expected_kzg_commitments,
                         blobs,
                         &kzg_proofs,
                     )
@@ -5021,7 +5021,7 @@ impl<T: BeaconChainTypes> BeaconChain<T> {
                     Sidecar::build_sidecar(
                         blobs_or_blobs_roots,
                         &block,
-                        &expected_kzg_commitments,
+                        expected_kzg_commitments,
                         kzg_proofs,
                     )
                     .map_err(BlockProductionError::FailedToBuildBlobSidecars)?,

diff --git a/beacon_node/execution_layer/src/test_utils/mock_builder.rs b/beacon_node/execution_layer/src/test_utils/mock_builder.rs
@@ -482,7 +482,9 @@ impl<E: EthSpec> mev_rs::BlindedBlockProvider for MockBuilder<E> {
             }),
             ForkName::Base | ForkName::Altair => return Err(MevError::InvalidFork),
         };
-        *message.gas_limit_mut() = cached_data.gas_limit;
+        // TODO(jimmy): not sure why this line was here, but I had to remove it because it changes
+        // the payload cache key (tree hash root of the payload)
+        // *message.gas_limit_mut() = cached_data.gas_limit;
 
         self.apply_operations(&mut message)?;
         let mut signature =