Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove faulty field from database and add calculating function instead #129

Merged
merged 5 commits into from
Feb 10, 2025

Conversation

dknopik
Copy link
Member

@dknopik dknopik commented Feb 7, 2025

We never calculated the faulty field of Cluster or read it from the DB until now. Remove the field and calculate it instead, it isn't worth caching such a cheap calculation

@dknopik dknopik requested a review from Zacholme7 February 7, 2025 13:57
Copy link
Member

@Zacholme7 Zacholme7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Zacholme7 Zacholme7 merged commit 1ec22bd into sigp:unstable Feb 10, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants