Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't use default endpoint for metrics #592

Merged
merged 1 commit into from
Oct 31, 2022
Merged

fix: don't use default endpoint for metrics #592

merged 1 commit into from
Oct 31, 2022

Conversation

seemk
Copy link
Contributor

@seemk seemk commented Oct 31, 2022

OTLP exporters already have their own checks for environment variables, if none exist they set it to the default (localhost:4317 or localhost:4318, depending on the exporter).

@seemk seemk requested review from a team as code owners October 31, 2022 14:21
@seemk seemk merged commit b3f0ffa into main Oct 31, 2022
@seemk seemk deleted the dont-overwrite-default-metrics-endpoint branch October 31, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t2t2 t2t2 t2t2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seemk @t2t2