Docs changes for GA #294
Merged
Docs changes for GA #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Rauno Viskus <Rauno56@users.noreply.github.com>
theletterf
commented
Sep 20, 2021
MIGRATING.md
Outdated
Comment on lines
73
to
85
| | OpenTracing environment variable | OpenTelemetry environment variable | notes | | ||
| | ---------------------------------- | -------------------------------------- | ----- | | ||
| | SIGNALFX_ACCESS_TOKEN | SPLUNK_ACCESS_TOKEN | | | ||
| | SIGNALFX_SERVICE_NAME | OTEL_SERVICE_NAME | | | ||
| | SIGNALFX_ENDPOINT_URL | _no direct equivalent_ | see [the notes on endpoint](#endpoint) | | ||
| | SIGNALFX_RECORDED_VALUE_MAX_LENGTH | OTEL_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMIT | | | ||
| | SIGNALFX_TRACING_DEBUG | _no direct equivalent_ | see [instrumentation logs](#instrumentation-logs) | | ||
| | SIGNALFX_SPAN_TAGS | OTEL_RESOURCE_ATTRIBUTES | format needs to be changed to `key1=val1,key2=val2` | | ||
| | SIGNALFX_LOGS_INJECTION | SPLUNK_LOGS_INJECTION | | | ||
| | SIGNALFX_LOGS_INJECTION_TAGS | OTEL_RESOURCE_ATTRIBUTES | there's no direct equivalent, but values specified in `OTEL_RESOURCE_ATTRIBUTES` will also be used for logs injection | | ||
| | SIGNALFX_ENABLED_PLUGINS | n/a | see [the README section about instrumentations](./README.md#custom-instrumentation-packages) | | ||
| | SIGNALFX_SERVER_TIMING_CONTEXT | SPLUNK_TRACE_RESPONSE_HEADER_ENABLED | | | ||
| | SIGNALFX_TRACING_ENABLED | OTEL_TRACE_ENABLED | | |
There was a problem hiding this comment.
@rauno56 As discussed, we need the definitive list of settings here.
Codecov Report
@@ Coverage Diff @@
## main #294 +/- ##
=======================================
Coverage 94.91% 94.91%
=======================================
Files 10 10
Lines 295 295
Branches 76 76
=======================================
Hits 280 280
Misses 15 15 Continue to review full report at Codecov.
|
|
Changed default port to 4317. |
rauno56
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs changes for GA. See the comments to each file.