Add app server span tags #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vovencij
reviewed
Jan 21, 2021
README.md
Outdated
| @@ -115,6 +115,15 @@ A simple wrapper for the Jaeger exporter of [opentelemetry-java](https://github. | |||
| ### More options | |||
| For more options see [here](https://github.com/open-telemetry/opentelemetry-java-instrumentation#configuration-parameters-subject-to-change) | |||
|
|
|||
| ## Span tags the Splunk distribution automatically creates | |||
|
|
|||
| This Splunk distribution automatically adds context to `SERVER` spans for application servers with span tags. These are the span tags: | |||
There was a problem hiding this comment.
maybe adds context to ... spans for known application servers using span tags?
vovencij
approved these changes
Jan 21, 2021
|
Argh, collector broke stuff for us. Ago's PR (#87) has the fix. Will have to wait until he merges. |
|
@brianashby-sfx Can you please rebase this PR? |
…app-server-span-tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides information about span tags the instrumentation adds to
SERVERspans for app servers.