Add deprecation notice and remove mention from front readme #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aurbiztondo-splunk
approved these changes
Jul 1, 2022
mateuszrzeszutek
approved these changes
Jul 1, 2022
laurit
reviewed
Jul 1, 2022
| @@ -39,6 +39,8 @@ export SPLUNK_METRICS_ENDPOINT=https://ingest.us0.signalfx.com | |||
| | `otel.exporter.jaeger.endpoint` | `OTEL_EXPORTER_JAEGER_ENDPOINT` | `http://localhost:9080/v1/trace` | Stable | The Jaeger endpoint to connect to. Setting this will override the `splunk.realm` property. | | |||
| | `otel.traces.exporter` | `OTEL_TRACES_EXPORTER` | `otlp` | Stable | Select the traces exporter to use. We recommend using either the OTLP exporter (`otlp`) or the Jaeger exporter (`jaeger-thrift-splunk`). | | |||
|
|
|||
| :warning: **Support for the `jaeger-thrift-splunk` exporter will be removed after December 17th, 2022. See the [deprecation notice](https://github.com/signalfx/signalfx-agent/blob/main/docs/smartagent-deprecation-notice.md) on the SmartAgent for details. ** :warning: | |||
There was a problem hiding this comment.
I don't think this is going to be that easy. Isn't this the recommended way for direct ingest also? Before deprecating it shouldn't there be an alternative for it? I don't think that any of the other exporters do anything with splunk.access.token
There was a problem hiding this comment.
I was wrong, splunk.access.token is also used for otlp exporter, so deprecating should be ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I assume we will want to keep support for
jaeger-thriftuntil the SmartAgent is deprecated in December. Once that happens, we can removejaeger-thriftfrom our distro.This change just adds a deprecation notice about that and removes the mention from the front page (to discourage creating new user dependencies on it).