Use alwaysOn() sampler #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkwatson
reviewed
Nov 20, 2020
| @@ -42,5 +43,9 @@ public void configure(TracerSdkManagement tracerManagement) { | |||
| if (jdbcSpanLowCardinalityNameEnabled()) { | |||
| tracerManagement.addSpanProcessor(new JdbcSpanRenamingProcessor()); | |||
| } | |||
|
|
|||
| tracerManagement.updateActiveTraceConfig(tracerManagement.getActiveTraceConfig().toBuilder() | |||
| .setSampler(Sampler.alwaysOn()) | |||
There was a problem hiding this comment.
The SDK itself defaults to alwaysOn. Is the otel agent doing something different?
There was a problem hiding this comment.
The SDK actually defaults to
private static final Sampler DEFAULT_SAMPLER = Sampler.parentBased(Sampler.alwaysOn());which works slightly different: for spans whose parent is not sampled it also returns the "not sampled" flag
There was a problem hiding this comment.
aha! You are totally correct. I conflated the two in my head.
jkwatson
approved these changes
Nov 20, 2020
Comment on lines
+31
to
+33
| return "open-telemetry-docker-dev.bintray.io/java/smoke-springboot-jdk" | ||
| + jdk | ||
| + ":20201105.347264626"; |
There was a problem hiding this comment.
I'm not entirely sure that this change is OK, but it seems that the latest image is simply too new, something related to @WithSpan must have changed.
There was a problem hiding this comment.
Yes, it got moved to a different package, and a different artifact in the past couple of weeks.
iNikem
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will always export the trace, even if the incoming b3 headers do not contain the
x-b3-sampledone