-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated SignalFX migration guide #183
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
as a code owner
April 6, 2021 12:43
Also please rebase - there's been a couple of changes to *.md files in the last few days. |
ghost
force-pushed
the
signalfx-migration-guide
branch
from
April 7, 2021 14:42
a286f64
to
3054548
Compare
@mateuszrzeszutek @jkwatson pls have another look |
jkwatson
reviewed
Apr 7, 2021
smoke-tests/src/test/java/com/splunk/opentelemetry/GlassFishSmokeTest.java
Outdated
Show resolved
Hide resolved
jkwatson
reviewed
Apr 7, 2021
ghost
force-pushed
the
signalfx-migration-guide
branch
from
April 7, 2021 15:42
3054548
to
5bff441
Compare
ghost
force-pushed
the
signalfx-migration-guide
branch
from
April 7, 2021 18:34
5bff441
to
7766c4b
Compare
jkwatson
approved these changes
Apr 7, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SignalFX -> OTEL migration guide updated with latest config properties and some minor spelling / formatting fixes.