Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add otel version of profiling metrics #1428

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Add otel version of profiling metrics #1428

merged 1 commit into from
Sep 14, 2023

Conversation

laurit
Copy link
Collaborator

@laurit laurit commented Sep 8, 2023

Add otel version of metrics used by profiling

@laurit laurit requested review from a team as code owners September 8, 2023 10:45
theletterf
theletterf reviewed Sep 13, 2023
View reviewed changes
Copy link
Contributor

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still have a metrics reference doc inside docs. Will the PR update it?

@laurit
Copy link
Collaborator Author

laurit commented Sep 14, 2023

We still have a metrics reference doc inside docs. Will the PR update it?

as far as I can tell that doc describes micrometer metrics, this pr is about otel metrics

@laurit laurit merged commit 7541dc4 into signalfx:main Sep 14, 2023
31 checks passed
@laurit laurit deleted the otel-profiling-metrics branch September 14, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theletterf theletterf theletterf left review comments

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurit @theletterf @mateuszrzeszutek