Verify in smoke tests that JVM metrics are exported #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkwatson
approved these changes
Mar 18, 2021
mateuszrzeszutek
force-pushed
the
add-metrics-to-fake-backend
branch
from
0f085be
to
5bff1e9
Compare
mateuszrzeszutek
changed the title
mateuszrzeszutek
force-pushed
the
add-metrics-to-fake-backend
branch
from
56e15fe
to
d4eac0b
Compare
mateuszrzeszutek
force-pushed
the
add-metrics-to-fake-backend
branch
from
d4eac0b
to
ca8e329
Compare
jkwatson
approved these changes
Mar 19, 2021
breedx-splk
approved these changes
Mar 19, 2021
...ke-backend/src/main/java/com/splunk/opentelemetry/smoketest/fakebackend/FakeBackendMain.java
Show resolved
Hide resolved
...ke-backend/src/main/java/com/splunk/opentelemetry/smoketest/fakebackend/FakeBackendMain.java
Show resolved
Hide resolved
smoke-tests/src/test/java/com/splunk/opentelemetry/TelemetryRetriever.java
Outdated
Show resolved
Hide resolved
smoke-tests/src/test/java/com/splunk/opentelemetry/TelemetryRetriever.java
Outdated
Show resolved
Hide resolved
|
I had to revert the Windows collector image changes and disable metrics on Windows: as it turned out, the otel-collector-contrib image is missing the changes from this PR: open-telemetry/opentelemetry-collector#2272 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements smoke tests verifying that our micrometer metrics get consumed by the collector correctly (and
runtime.is added).