Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instrumentation for gorm #98

Merged
merged 6 commits into from
Sep 28, 2021
Merged

Add instrumentation for gorm #98

merged 6 commits into from
Sep 28, 2021

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Sep 13, 2021

This new module instruments the github.com/jinzhu/gorm package. The instrumentation wraps the sql.DB used by "github.com/jinzhu/gorm".DB with the existing instrumentation from github.com/signalfx/splunk-otel-go/instrumentation/database/sql/splunksql.

  • Comply with OpenTelemetry database semantic conventions (done using the already compliant github.com/signalfx/splunk-otel-go/instrumentation/database/sql/splunksql instrumentation)
  • Package documentation
  • Exported objects are documented
  • Tests and linting are passing
  • Includes dependabot config
  • Library added to README.md

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2021

Codecov Report

Merging #98 (d2b9240) into main (96b06ee) will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   81.07%   81.32%   +0.24%     
==========================================
  Files          21       22       +1     
  Lines         856      862       +6     
==========================================
+ Hits          694      701       +7     
+ Misses        130      128       -2     
- Partials       32       33       +1     
Flag Coverage Δ
Linux 80.16% <100.00%> (+0.25%) ⬆️
Windows 80.62% <100.00%> (+0.25%) ⬆️
macOS 79.46% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mentation/github.com/jinzhu/gorm/splunkgorm/sql.go 100.00% <100.00%> (ø)
instrumentation/database/sql/splunksql/config.go 83.80% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96b06ee...d2b9240. Read the comment docs.

@MrAlias MrAlias marked this pull request as ready for review September 27, 2021 18:47
@MrAlias MrAlias requested review from a team as code owners September 27, 2021 18:47
Copy link
Contributor

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it only misses a line in the CHANGELOG

@MrAlias MrAlias enabled auto-merge (squash) September 28, 2021 15:57
@MrAlias MrAlias merged commit ecebf9c into signalfx:main Sep 28, 2021
@MrAlias MrAlias deleted the splunkgorm branch September 28, 2021 16:01
@MrAlias MrAlias mentioned this pull request Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants