Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instrumentation for the lib/pq posgres driver package #92

Merged
merged 10 commits into from
Sep 27, 2021

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Sep 10, 2021

  • README
  • End-to-end tests
  • Unit tests
  • Code complete
  • Documented

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2021

Codecov Report

Merging #92 (8c614c4) into main (e640666) will decrease coverage by 7.43%.
The diff coverage is 61.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
- Coverage   87.58%   80.14%   -7.44%     
==========================================
  Files          18       20       +2     
  Lines         572      806     +234     
==========================================
+ Hits          501      646     +145     
- Misses         52      129      +77     
- Partials       19       31      +12     
Flag Coverage Δ
Linux 78.90% <57.69%> (-8.68%) ⬇️
Windows 79.40% <60.68%> (-7.66%) ⬇️
macOS 78.16% <56.41%> (-8.90%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/github.com/lib/pq/splunkpq/internal/connector.go 56.78% <56.78%> (ø)
instrumentation/github.com/lib/pq/splunkpq/sql.go 91.42% <91.42%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e640666...8c614c4. Read the comment docs.

@MrAlias MrAlias changed the title lib/pq driver instrumentation PoC Add instrumentation for the lib/pq posgres driver package Sep 24, 2021
@MrAlias MrAlias marked this pull request as ready for review September 24, 2021 18:00
@MrAlias MrAlias requested review from a team as code owners September 24, 2021 18:00
@MrAlias MrAlias merged commit d73eb46 into signalfx:main Sep 27, 2021
@MrAlias MrAlias deleted the splunkpq branch September 27, 2021 16:41
@MrAlias MrAlias mentioned this pull request Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants