Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instrumentation for the pgx package #91

Merged
merged 20 commits into from
Sep 27, 2021
Merged

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Sep 9, 2021

  • README
  • End-to-end tests
  • Unit tests
  • Code complete
  • Documented

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2021

Codecov Report

Merging #91 (45c6e56) into main (bad256c) will increase coverage by 0.92%.
The diff coverage is 96.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   80.14%   81.07%   +0.92%     
==========================================
  Files          20       21       +1     
  Lines         806      856      +50     
==========================================
+ Hits          646      694      +48     
- Misses        129      130       +1     
- Partials       31       32       +1     
Flag Coverage Δ
Linux 79.90% <96.00%> (+0.99%) ⬆️
Windows 80.37% <96.00%> (+0.96%) ⬆️
macOS 79.20% <96.00%> (+1.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...trumentation/github.com/jackc/pgx/splunkpgx/sql.go 96.00% <96.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bad256c...45c6e56. Read the comment docs.

@MrAlias MrAlias changed the title pgx driver instrumentation PoC Add instrumentation for the pgx package Sep 24, 2021
@MrAlias MrAlias marked this pull request as ready for review September 24, 2021 16:05
@MrAlias MrAlias requested review from a team as code owners September 24, 2021 16:05
@MrAlias MrAlias enabled auto-merge (squash) September 24, 2021 16:06
@MrAlias MrAlias disabled auto-merge September 24, 2021 16:29
@MrAlias MrAlias merged commit 14f012e into signalfx:main Sep 27, 2021
@MrAlias MrAlias deleted the splunkpgx branch September 27, 2021 17:38
@MrAlias MrAlias mentioned this pull request Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants