Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github.com/graph-gophers/graphql-go instrumentation #232

Merged
merged 9 commits into from
Dec 14, 2021

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Dec 8, 2021

This new module instruments the github.com/graph-gophers/graphql-go module.

  • Comply with OpenTelemetry semantic conventions (there are non currently)
  • Package documentation
  • Exported objects are documented
  • Tests and linting are passing
  • Includes dependabot config
  • Library added to README.md
  • CHANGELOG.md updated

@MrAlias MrAlias requested a review from TomRoSystems December 13, 2021 20:56
@MrAlias MrAlias marked this pull request as ready for review December 13, 2021 20:56
@MrAlias MrAlias requested review from a team as code owners December 13, 2021 20:56
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2021

Codecov Report

Merging #232 (de221aa) into main (ed64e83) will decrease coverage by 0.46%.
The diff coverage is 77.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
- Coverage   77.47%   77.01%   -0.47%     
==========================================
  Files          45       47       +2     
  Lines        2087     2149      +62     
==========================================
+ Hits         1617     1655      +38     
- Misses        429      449      +20     
- Partials       41       45       +4     
Flag Coverage Δ
Linux 77.01% <77.41%> (+0.01%) ⬆️
Windows ?
macOS 75.10% <77.41%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../graph-gophers/graphql-go/splunkgraphql/graphql.go 76.47% <76.47%> (ø)
...m/graph-gophers/graphql-go/splunkgraphql/option.go 81.81% <81.81%> (ø)
...n/github.com/lib/pq/splunkpq/internal/connector.go 51.75% <0.00%> (-5.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed64e83...de221aa. Read the comment docs.

@MrAlias MrAlias enabled auto-merge (squash) December 14, 2021 16:59
@MrAlias MrAlias merged commit fc5ab1d into signalfx:main Dec 14, 2021
@MrAlias MrAlias deleted the splunkgraphql branch December 14, 2021 17:04
@MrAlias MrAlias mentioned this pull request Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants