Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tidwall/buntdb instrumentation #228

Merged
merged 36 commits into from
Dec 14, 2021

Conversation

TomRoSystems
Copy link
Contributor

@TomRoSystems TomRoSystems commented Dec 8, 2021

This new module instruments the github.com/tidwall/buntdb package.

  • Comply with OpenTelemetry HTTP semantic conventions
  • Package documentation
  • Exported objects are documented
  • Tests and linting are passing
  • Includes dependabot config
  • Library added to README.md
  • CHANGELOG.md updated

@TomRoSystems TomRoSystems requested review from a team as code owners December 8, 2021 16:34
@MrAlias
Copy link
Contributor

MrAlias commented Dec 8, 2021

Please add dependabot configuration for the added modules (make gendependabot) and be sure to fix all test failures.

TomRoSystems and others added 3 commits December 9, 2021 14:48
Merging suggestions from code review

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2021

Codecov Report

Merging #228 (965491b) into main (ed64e83) will decrease coverage by 0.08%.
The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
- Coverage   77.47%   77.39%   -0.09%     
==========================================
  Files          45       47       +2     
  Lines        2087     2358     +271     
==========================================
+ Hits         1617     1825     +208     
- Misses        429      485      +56     
- Partials       41       48       +7     
Flag Coverage Δ
Linux 76.97% <76.47%> (-0.03%) ⬇️
Windows 75.32% <76.47%> (+0.21%) ⬆️
macOS 75.23% <76.47%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
build/pipeline.go 2.76% <0.00%> (ø)
...n/github.com/tidwall/buntdb/splunkbuntdb/config.go 55.55% <55.55%> (ø)
...n/github.com/tidwall/buntdb/splunkbuntdb/buntdb.go 87.29% <87.29%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed64e83...965491b. Read the comment docs.

Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The splunkbuntdb package needs a README similar to existing ones.

@TomRoSystems TomRoSystems requested a review from MrAlias December 14, 2021 16:29
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add tests for the Open function and both WithContext methods?

@MrAlias MrAlias enabled auto-merge (squash) December 14, 2021 19:42
@MrAlias MrAlias merged commit 23d66eb into signalfx:main Dec 14, 2021
@MrAlias MrAlias mentioned this pull request Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants