-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tidwall/buntdb instrumentation #228
Conversation
instrumentation/github.com/tidwall/buntdb/splunkbuntdb/test/go.mod
Outdated
Show resolved
Hide resolved
instrumentation/github.com/tidwall/buntdb/splunkbuntdb/buntdb.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/tidwall/buntdb/splunkbuntdb/buntdb.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/tidwall/buntdb/splunkbuntdb/buntdb.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/tidwall/buntdb/splunkbuntdb/buntdb.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/tidwall/buntdb/splunkbuntdb/test/buntdb_test.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/tidwall/buntdb/splunkbuntdb/test/buntdb_test.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/tidwall/buntdb/splunkbuntdb/test/buntdb_test.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/tidwall/buntdb/splunkbuntdb/test/go.mod
Outdated
Show resolved
Hide resolved
Please add dependabot configuration for the added modules ( |
instrumentation/github.com/tidwall/buntdb/splunkbuntdb/config.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/tidwall/buntdb/splunkbuntdb/buntdb.go
Outdated
Show resolved
Hide resolved
Merging suggestions from code review Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
instrumentation/github.com/tidwall/buntdb/splunkbuntdb/example_test.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/syndtr/goleveldb/leveldb/splunkleveldb/go.mod
Outdated
Show resolved
Hide resolved
instrumentation/github.com/tidwall/buntdb/splunkbuntdb/example_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
…k-otel-go into trojek-migrate-buntdb
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
…_test.go Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #228 +/- ##
==========================================
- Coverage 77.47% 77.39% -0.09%
==========================================
Files 45 47 +2
Lines 2087 2358 +271
==========================================
+ Hits 1617 1825 +208
- Misses 429 485 +56
- Partials 41 48 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The splunkbuntdb package needs a README similar to existing ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add tests for the Open
function and both WithContext
methods?
This new module instruments the
github.com/tidwall/buntdb
package.