Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use OTel autoprop package #1171

Merged
merged 3 commits into from
Jul 12, 2022
Merged

refactor: use OTel autoprop package #1171

merged 3 commits into from
Jul 12, 2022

Conversation

pellared
Copy link
Contributor

Refactor to use https://pkg.go.dev/go.opentelemetry.io/contrib/propagators/autoprop

The refactoring is nicely tested by the following existing tests:

$ go test -v -run TestConfig/Propagator
=== RUN   TestConfig
=== RUN   TestConfig/Propagator
=== RUN   TestConfig/Propagator/DefaultValue
=== RUN   TestConfig/Propagator/EnvironmentVariableOverride
--- PASS: TestConfig (0.00s)
    --- PASS: TestConfig/Propagator (0.00s)
        --- PASS: TestConfig/Propagator/DefaultValue (0.00s)
        --- PASS: TestConfig/Propagator/EnvironmentVariableOverride (0.00s)
PASS
ok      github.com/signalfx/splunk-otel-go/distro       0.154s

@pellared pellared requested review from a team as code owners July 12, 2022 07:53
@pellared
Copy link
Contributor Author

This PR is blocked by #1172

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2022

Codecov Report

Merging #1171 (08a7fc4) into main (89df9c8) will decrease coverage by 0.76%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1171      +/-   ##
==========================================
- Coverage   79.21%   78.44%   -0.77%     
==========================================
  Files          55       55              
  Lines        2771     2719      -52     
==========================================
- Hits         2195     2133      -62     
- Misses        528      536       +8     
- Partials       48       50       +2     
Flag Coverage Δ
Linux 78.44% <100.00%> (-0.41%) ⬇️
Windows ?
macOS 74.62% <100.00%> (-0.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
distro/config.go 100.00% <100.00%> (ø)
distro/otel.go 65.57% <100.00%> (-0.56%) ⬇️
...n/github.com/lib/pq/splunkpq/internal/connector.go 51.75% <0.00%> (-5.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89df9c8...08a7fc4. Read the comment docs.

@MrAlias MrAlias merged commit be7fe90 into signalfx:main Jul 12, 2022
@pellared pellared deleted the use-autoprop branch July 12, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants