Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ansible: replace SFx.NET with Splunk OTel for dotnet #5833

Merged
merged 34 commits into from
Jan 29, 2025
Merged

Ansible: replace SFx.NET with Splunk OTel for dotnet #5833

merged 34 commits into from
Jan 29, 2025

Conversation

pjanotti
Copy link
Contributor

@pjanotti pjanotti commented Jan 23, 2025 •
edited
Loading

Replaces SignalFx Instrumentation for .NET with Splunk Distribution of OpenTelemetry .NET on the Ansible playbook.

Renamed configuration settings from signafx_dotnet_auto_instrumentation_* to respective splunk_dotnet_auto_instrumentation_*. Notice that signalfx_dotnet_auto_instrumentation_global_tags was mapped to the more generic and already existing splunk_otel_auto_instrumentation_resource_attributes.

pjanotti added 30 commits January 21, 2025 12:45
@pjanotti
Rename signalfx_dotnet to splunk_dotnet Ansible vars
6e96e25
@pjanotti
Rename custom env vars for .NET instrumentation
ed81ee3
@pjanotti
Remove verification of machine wide env vars
c98ee60
@pjanotti
Adjust env vars
27ad8d7
@pjanotti
Update Splunk doc links
f266889
@pjanotti
Update Ansible changelog
e4d8f9d
@pjanotti
Download and running Splunk OTel .NET Install
822b435
@pjanotti
Merge branch 'main' into ansible-replace-sfx-with-splunk-otel-dotnet
f80bcf3
@pjanotti
Lint fixes
55cac93
@pjanotti
Change version for converge test
36c0e74
@pjanotti
Use win_powershell instead of the generic win_shell
ba68157
@pjanotti
Update CLR Profiler GUID
c003faf
@pjanotti
Remove hardcoded version
e15eedf
@pjanotti
Missed replacements
f776e89
@pjanotti
Do not set OTel zc for dotnet on default env vars
ff6a39b
@pjanotti
Fix splunk.zc.method
95d09e3
@pjanotti
Skip molecure idempotence test for install splunk-otel-dotnet
28e878f
@pjanotti
Change splunk.zc.method
6096e43
@pjanotti
Fix missing double-quotes
ba471b6
@pjanotti
Fix OTEL_RESOURCE_ATTRIBUTES
a54c14b
@pjanotti
Fix line too long
5b4aabf
@pjanotti
Remove leftover *_global_tags
79d0cc5
@pjanotti
Fix cmdlet name typo
fa24364
@pjanotti
Fix code to get installed version
54bd4ba
@pjanotti
Return value for win_powershell
5139af4
@pjanotti
Fix lint: long line
ec51820
@pjanotti
Fix "Set system-wide registry value" task
81cf2ff
@pjanotti
Task to get .NET instrumentation is not idempotent
372af13
@pjanotti
Another idempotency skip
67b6ed0
@pjanotti
Skip idempotency test for "Set IIS registry value"
e8c6f7d
@pjanotti pjanotti marked this pull request as ready for review January 28, 2025 17:36
@pjanotti pjanotti requested review from a team as code owners January 28, 2025 17:36
@pjanotti pjanotti changed the title [draft] Ansible replace sfx with splunk otel dotnet Ansible: replace SFx.NET with Splunk OTel for dotnet Jan 28, 2025
atoulme
atoulme approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kielek
Copy link

Kielek commented Jan 29, 2025

🎉

@pjanotti pjanotti merged commit e21ecbb into signalfx:main Jan 29, 2025
40 checks passed
@pjanotti pjanotti deleted the ansible-replace-sfx-with-splunk-otel-dotnet branch January 29, 2025 15:43
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atoulme atoulme atoulme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pjanotti @Kielek @atoulme