deprecate nagios monitor #5172
deprecate nagios monitor #5172
Conversation
There was a problem hiding this comment.
@pauljwil I think we need corresponding deprecation warnings on the docs https://docs.splunk.com/observability/en/gdi/monitors-monitoring/nagios.html
Unless @atoulme is tracking this some other way.
| @@ -68,6 +68,8 @@ var ( | |||
| // Configure and kick off internal metric collection | |||
| func (m *Monitor) Configure(conf *Config) error { | |||
| m.logger = logrus.WithFields(logrus.Fields{"monitorType": monitorType, "monitorID": conf.MonitorID}) | |||
| m.logger.Warn("[NOTICE] The nagios monitor is deprecated and will be removed in a future release.") | |||
There was a problem hiding this comment.
I believe we use [WARNING] in other places. Maybe better to be consistent if I'm not missing other places where we do [NOTICE]
There was a problem hiding this comment.
it's already logging at WARN level and therefore will show as a warning. We use [NOTICE] for all deprecation notices so far.
https://github.com/search?q=repo%3Asignalfx%2Fsplunk-otel-collector%20%5BNOTICE%5D&type=code
You are correct that we use [WARNING], but only in the concept of config converters where we use log.Println:
https://github.com/search?q=repo%3Asignalfx%2Fsplunk-otel-collector+%5BWARNING%5D&type=code
atoulme
force-pushed
the
deprecate_nagios
branch
from
8f438d7
to
fc9d93a
Compare
|
@aurbiztondo-splunk not sure if you recall but here is another deprecation that we did https://github.com/splunk/private-o11y-docs/pull/1699 - I am not sure if in the present case we go with a precise date as in the link. |
|
Thanks @pjanotti - will check with Aunsh as well! Docs updated in https://github.com/splunk/private-o11y-docs/pull/2292 |
Description:
Deprecate nagios monitor.