Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux installer script: decouple the endpoint and protocol options #5164

Merged
merged 1 commit into from
Aug 1, 2024
Merged

linux installer script: decouple the endpoint and protocol options #5164

merged 1 commit into from
Aug 1, 2024

Conversation

jeffreyc-splunk
Copy link
Contributor

After clarification from @pjanotti, remove the dependency between the --otlp-endpoint and --otlp-endpoint-protocol options for configuring the OTEL_EXPORTER_OTLP_ENDPOINT and OTEL_EXPORTER_OTLP_PROTOCOL env vars.

@jeffreyc-splunk jeffreyc-splunk marked this pull request as ready for review July 31, 2024 19:33
@jeffreyc-splunk jeffreyc-splunk requested review from a team as code owners July 31, 2024 19:33
@jeffreyc-splunk jeffreyc-splunk mentioned this pull request Jul 31, 2024
Merged
2 tasks
@jeffreyc-splunk jeffreyc-splunk merged commit 5900428 into main Aug 1, 2024
178 checks passed
@jeffreyc-splunk jeffreyc-splunk deleted the installer-endpoint-protocol branch August 1, 2024 14:42
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atoulme atoulme atoulme approved these changes

@pjanotti pjanotti pjanotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffreyc-splunk @atoulme @pjanotti