[discovery] Fix crashing collector if discovered mongodb isn't reachable #4911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
fix-mongodb-discovery
branch
from
36e75d6 to
a1c18d2
Compare
Reduce the connection timeout to 5 seconds. Otherwise, it's 60s for every mongodb query, which accumulates to a significant delay and makes the collector being killed in k8s.
dmitryax
force-pushed
the
fix-mongodb-discovery
branch
from
a1c18d2 to
9339d18
Compare
atoulme
approved these changes
May 30, 2024
crobert-1
approved these changes
May 30, 2024
samiura
approved these changes
May 30, 2024
|
@dmitryax thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the connection timeout to 5s seconds. Otherwise, it's the 60s for every Mongodb query, which accumulates to a significant delay and makes the collector killed in k8s.