ecs-metadata: support dimensionToUpdate
config field
#4091
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add a
dimensionToUpdate
config field to the ecs-metadata monitor to allow configuring dimension updates on either thecontainer_name
andcontainer_id
dimension. Since container_name's can be long lived, perpetuating entities to update becomes unnecessary and setting to the more ephemeralcontainer_id
is preferable.My plan is to update the default value tocontainer_id
in a subsequent release but can understand wanting to here instead.edit: updated to sync on
container_id
by default, w/ bw-compatibility option w/ new config field.