Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecs-metadata: support dimensionToUpdate config field #4091

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

rmfitzpatrick
Copy link
Contributor

@rmfitzpatrick rmfitzpatrick commented Dec 18, 2023

These changes add a dimensionToUpdate config field to the ecs-metadata monitor to allow configuring dimension updates on either the container_name and container_id dimension. Since container_name's can be long lived, perpetuating entities to update becomes unnecessary and setting to the more ephemeral container_id is preferable. My plan is to update the default value to container_id in a subsequent release but can understand wanting to here instead.

edit: updated to sync on container_id by default, w/ bw-compatibility option w/ new config field.

@rmfitzpatrick rmfitzpatrick requested review from a team as code owners December 18, 2023 22:00
@rmfitzpatrick rmfitzpatrick marked this pull request as draft December 18, 2023 22:00
@rmfitzpatrick
Copy link
Contributor Author

rmfitzpatrick commented Dec 18, 2023

@dloucasfx would appreciate your thoughts on if this is too conservative and we should simply update the dimension to sync to container_id without a transitional option and future default value change.

edit: I've gone ahead and updated to container_id without an intermediary default change w/ a breaking change note.

@rmfitzpatrick rmfitzpatrick marked this pull request as ready for review December 21, 2023 15:08
@rmfitzpatrick rmfitzpatrick force-pushed the ecsmetadatactridupdate branch from 78ed6a5 to 6fe05ef Compare January 5, 2024 18:03
@rmfitzpatrick rmfitzpatrick requested a review from a team as a code owner January 5, 2024 18:03
@rmfitzpatrick rmfitzpatrick force-pushed the ecsmetadatactridupdate branch from 6fe05ef to f76c19f Compare January 5, 2024 18:10
@rmfitzpatrick rmfitzpatrick force-pushed the ecsmetadatactridupdate branch from f76c19f to 27ccd78 Compare January 8, 2024 21:45
@rmfitzpatrick rmfitzpatrick merged commit 25aba18 into main Jan 9, 2024
45 checks passed
@delete-merged-branch delete-merged-branch bot deleted the ecsmetadatactridupdate branch January 9, 2024 15:32
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants