Support confmap providers in discovery config #3874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
samiura
force-pushed
the
config-source-integration-attempt-with-discovery-mode-2
branch
from
141e402 to
8195907
Compare
|
I have read the CLA Document and I hereby sign the CLA |
srv-gh-o11y-gdi-cla
added a commit
to splunk/cla-agreement
that referenced
this pull request
Oct 30, 2023
samiura
force-pushed
the
config-source-integration-attempt-with-discovery-mode-2
branch
from
8195907 to
cc1fca4
Compare
samiura
force-pushed
the
config-source-integration-attempt-with-discovery-mode-2
branch
from
9a8ea48 to
ff6dc36
Compare
|
@samiura do you mind updating this existing test to confirm that unexpanded provider directives are used in the initial config? I think replacing this w/ |
samiura
force-pushed
the
config-source-integration-attempt-with-discovery-mode-2
branch
2 times, most recently
from
cc5a26d to
10fa78a
Compare
samiura
force-pushed
the
config-source-integration-attempt-with-discovery-mode-2
branch
from
69cadea to
b6397a2
Compare
samiura
changed the title
samiura
force-pushed
the
config-source-integration-attempt-with-discovery-mode-2
branch
2 times, most recently
from
0d684e3 to
b43dba7
Compare
rmfitzpatrick
approved these changes
Nov 1, 2023
samiura
force-pushed
the
config-source-integration-attempt-with-discovery-mode-2
branch
from
b43dba7 to
db99643
Compare
samiura
deleted the
config-source-integration-attempt-with-discovery-mode-2
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding option for arbitrary env var to authenticate for dbs on discovery mode
Description:
Link to Splunk idea:
Testing:
Documentation: