add properties.discovery.yaml support #2740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmfitzpatrick
commented
Mar 17, 2023
| These properties can be in `config.d/properties.discovery.yaml` or specified at run time with `--set` command line options. | ||
|
|
||
| Each discovery property also has an equivalent environment variable form using `_x<hex pair>_` encoded delimiters for |
There was a problem hiding this comment.
I plan on adding a cli helper of some kind in the future to make producing these env vars possible for the user similar to what we offer in the bundle.d template helpers.
rmfitzpatrick
force-pushed
the
discopropertiesyaml
branch
from
494a254 to
f587a65
Compare
crobert-1
reviewed
Mar 17, 2023
internal/confmapprovider/discovery/testdata/invalid-properties.d/properties.discovery.yaml
Outdated
Show resolved
Hide resolved
internal/confmapprovider/discovery/testdata/config.d/properties.discovery.yaml
Show resolved
Hide resolved
rmfitzpatrick
force-pushed
the
discopropertiesyaml
branch
2 times, most recently
from
9073abb to
079b62b
Compare
crobert-1
approved these changes
Mar 20, 2023
rmfitzpatrick
force-pushed
the
discopropertiesyaml
branch
3 times, most recently
from
6caf10f to
efc86c3
Compare
rmfitzpatrick
force-pushed
the
discopropertiesyaml
branch
from
efc86c3 to
e7fa477
Compare
atoulme
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add the ability to specify discovery properties in a single
config.d/properties.discovery.yamlfile that are merged w/ env/cli set properties.edit: these changes also fix a bug I introduced where
configDirRootRegexwas using a group in a range exclusion.