Adds redis and an example to run it #2096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: otelcol/redis | ||
| metrics: | ||
| - name: redis/uptime | ||
| type: IntMonotonicCumulativeSum |
There was a problem hiding this comment.
are there any attributes we can assert on?
hughesjj
force-pushed
the
add_example_redis_and_sfx
branch
from
f4f6a63 to
b77e717
Compare
atoulme
reviewed
Oct 10, 2022
rmfitzpatrick
previously requested changes
Oct 11, 2022
ccordi
reviewed
Oct 13, 2022
hughesjj
force-pushed
the
add_example_redis_and_sfx
branch
from
b77e717 to
625b29a
Compare
|
Please rebase |
atoulme
reviewed
Dec 15, 2022
atoulme
reviewed
Dec 15, 2022
| # Splunk HTTP Event Collector token. | ||
| token: "00000000-0000-0000-0000-0000000000000" | ||
| # URL to a Splunk instance to send data to. | ||
| endpoint: "https://splunk_redis:8088/services/collector" |
There was a problem hiding this comment.
splunk_redis is not defined in the docker compose file.
atoulme
reviewed
Dec 15, 2022
| # For this demo, we use a self-signed certificate on the Splunk docker instance, so this flag is set to true. | ||
| insecure_skip_verify: true | ||
| signalfx: | ||
| # https://aws-otel.github.io/docs/partners/splunk#configuring-signalfx-exporter |
There was a problem hiding this comment.
point to our own docs instead, or the official otel contrib repo
hughesjj
force-pushed
the
add_example_redis_and_sfx
branch
from
1677fea to
23a523c
Compare
hughesjj
force-pushed
the
add_example_redis_and_sfx
branch
from
23a523c to
d6f3be5
Compare
atoulme
reviewed
Jan 4, 2023
| metrics/logging: | ||
| receivers: [redis] | ||
| processors: [batch] | ||
| exporters: [logging] |
There was a problem hiding this comment.
you can write this as:
metrics/both:
receivers: [redis]
processors: [batch]
exporters: [logging, signalfx]
you don't have to and in effect this is going to define the exact same output, but just in case that wasn't an explicit set up.
Talked it over with PM and we'd rather get this in the hands of customers now while those go out in parallel. |
Co-authored-by: Antoine Toulme <antoine@toulme.name>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Splunk employees, see https://signalfuse.atlassian.net/browse/OTL-1570
Adopts redis into splunk's distribution of the otel collector
Add an example to prove it works for good measure
All of the non-example code was resurrected from https://signalfuse.atlassian.net/browse/OTL-915