This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
SA deprecation notice for April 15 GA #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pohannigansfx
requested review from
asuresh4,
jchengsfx,
jrcamp,
keitwb and
mstumpfx
as code owners
pohannigansfx
changed the title
pohannigansfx
changed the title
|
PR now includes all files in this repo that should have Smart Agent deprecation notice for Olly GA |
keitwb
reviewed
Apr 15, 2021
gschatz-splunk
approved these changes
Apr 15, 2021
ghost
reviewed
Apr 15, 2021
|
Approved by Principal PM -- please merge this into the repo (code owner review/approval still required) |
asuresh4
force-pushed
the
SA-deprecation-for-April15
branch
from
fe9ac59
to
6c90e7f
Compare
|
@pohannigansfx - I pushed some updates to fix tests. I took a look and I believe your original changes are intact. PTAL |
|
@asuresh4 you are correct. If you don't mind a final force push, I revised one line just a bit -- but otherwise LGTM. |
|
Thanks, @asuresh4. We good to go and merge this thing? (I don't have merge permissions in this repo) |
asuresh4
approved these changes
Apr 15, 2021
There was a problem hiding this comment.
The latest failure in check_links job seems unrelated to this PR. And the URL actually is accessible.
FILE: /usr/src/signalfx-agent/docs/monitors/collectd-php-fpm.md
[✖] https://www.php.net/manual/en/install.fpm.configuration.php#pm.status-path → Status: 503
5 links checked.
ERROR: 1 dead links found!
[✖] https://www.php.net/manual/en/install.fpm.configuration.php#pm.status-path → Status: 503
rmfitzpatrick
pushed a commit
that referenced
this pull request
Apr 23, 2021
Deprecation Notice: * SA deprecation notice for April 15 GA (#1720) * Pull deprecation notice to integrations repo (#1721) Changes: * prometheus-exporter monitor: Don't set timestamp (#1703) * Update ingest-protocols lib (#1704) * sfxcollectd: Fix single item handling with #flatten (#1705) * Allow non defined in collectd/jenkins metrics (#1706) * writer: Sanitize token in HTTP error logs (#1710) * excludeJobMetrics parameter available on collectd-jenkins v2.4.0 (#1712) + Update scripts, docs, and CI for main (#1724) * Add an option to control remote config watch (#1730) * Security updates for third-party dependencies Breaking Changes: * Use static 404 for unsupported signalfx-forwarder paths instead of 200 (#1731)
Merged
rmfitzpatrick
pushed a commit
that referenced
this pull request
Apr 23, 2021
Deprecation Notice: * SA deprecation notice for April 15 GA (#1720) * Pull deprecation notice to integrations repo (#1721) Changes: * prometheus-exporter monitor: Don't set timestamp (#1703) * Update ingest-protocols lib (#1704) * sfxcollectd: Fix single item handling with #flatten (#1705) * Allow non defined in collectd/jenkins metrics (#1706) * writer: Sanitize token in HTTP error logs (#1710) * excludeJobMetrics parameter available on collectd-jenkins v2.4.0 (#1712) * Update scripts, docs, and CI for main (#1724) * Add an option to control remote config watch (#1730) * Security updates for third-party dependencies Breaking Changes: * Use static 404 for unsupported signalfx-forwarder paths instead of 200 (#1731)
rmfitzpatrick
added a commit
that referenced
this pull request
Apr 23, 2021
Deprecation Notice: * SA deprecation notice for April 15 GA (#1720) * Pull deprecation notice to integrations repo (#1721) Changes: * prometheus-exporter monitor: Don't set timestamp (#1703) * Update ingest-protocols lib (#1704) * sfxcollectd: Fix single item handling with #flatten (#1705) * Allow non defined in collectd/jenkins metrics (#1706) * writer: Sanitize token in HTTP error logs (#1710) * excludeJobMetrics parameter available on collectd-jenkins v2.4.0 (#1712) * Update scripts, docs, and CI for main (#1724) * Add an option to control remote config watch (#1730) * Security updates for third-party dependencies Breaking Changes: * Use static 404 for unsupported signalfx-forwarder paths instead of 200 (#1731)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecation notice in documentation for Smart Agent -- please do not merge until April 15. PR includes files with a note about deprecation that link back to new Deprecation Notice page. This is only for files in the signalfx-agent repo.