Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

Commit

Permalink
bump goroutine limit for perf test
Browse files Browse the repository at this point in the history
  • Loading branch information
Ryan Fitzpatrick committed Feb 2, 2022
1 parent 67d180e commit 9b6c91e
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions tests/basic/perf_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -198,8 +198,14 @@ def test_service_correlation_api_down():
break
peak_heap = new

# ensure our routine count isn't too high
agent.pprof_client.assert_goroutine_count_under(150)
# Ensure our routine count isn't too high.
# When adopting go 1.17.6 there appeared to be 2 per persistent connection:
# 120 @ 0x437f76 0x430893 0x463029 0x4d8472 0x4d97da 0x4d97c8 0x5dcf49 0x5edfc5 0x6ec70e 0x52d0c3 0x52d21d 0x6ed4cc 0x468b41
# 0x463028 internal/poll.runtime_pollWait+0x88 /usr/local/go/src/runtime/netpoll.go:234
# 120 @ 0x437f76 0x447d12 0x6ef19b 0x468b41
# 0x6ef19a net/http.(*persistConn).writeLoop+0xfa /usr/local/go/src/net/http/transport.go:2386

agent.pprof_client.assert_goroutine_count_under(300)

# ensure the heap profile has come down some
agent.pprof_client.assert_heap_alloc_under(peak_heap / 1.5)

0 comments on commit 9b6c91e

Please sign in to comment.