Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ingest endpoints for data ingestion #222

Merged
merged 1 commit into from
Sep 29, 2021
Merged

fix ingest endpoints for data ingestion #222

merged 1 commit into from
Sep 29, 2021

Conversation

jgheewala
Copy link
Contributor

No description provided.

mdubbyap
mdubbyap reviewed Sep 27, 2021
View reviewed changes
Copy link
Contributor

@mdubbyap mdubbyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also am unsure why this helps anything, it's not like we're going to not be maintaining both...

sfxclient/httpsink.go Outdated Show resolved Hide resolved
@jgheewala
Copy link
Contributor Author

I also am unsure why this helps anything, it's not like we're going to not be maintaining both...

it's to ensure that any customer using defaults are not using old endpoints.

@jgheewala jgheewala merged commit beef535 into master Sep 29, 2021
@jgheewala jgheewala deleted the fix_endpoints branch September 29, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdubbyap mdubbyap mdubbyap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgheewala @mdubbyap