This repository has been archived by the owner on Aug 13, 2024. It is now read-only.
Update comments to the current MetricType #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
mdubbyap
reviewed
Feb 1, 2022
| */ | ||
|
|
||
| // Used for non-continuous quantities (that is, measurements where there is a fixed | ||
| // set of meaningful values). This is essentially a special case of gauge that reports a string value. |
There was a problem hiding this comment.
i don't even know what will happen if an enum is sent in... i don't think this is actually implemented.
There was a problem hiding this comment.
No idea, I've tried to document it, if you think I should remove it I am happy to do it.
mdubbyap
approved these changes
Feb 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com