Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete emoji via a new fork of emoji-panel #1893

Merged
merged 1 commit into from
Dec 14, 2017

Conversation

scottnonnenberg
Copy link
Contributor

Fixes #1892

In many cases this removes generic emoji in favor of new gendered
options (one of which was a copy of the previous generic emoji anyway).

In many cases this removes generic emoji in favor of new gendered
options (one of which was a copy of the previous generic emoji anyway).
@scottnonnenberg scottnonnenberg merged commit 18ee8a3 into development Dec 14, 2017
@scottnonnenberg scottnonnenberg deleted the remove-obsolete-emoji branch December 14, 2017 19:30
scottnonnenberg added a commit that referenced this pull request Dec 15, 2017
Fix issue where .tif file attachments could not be sent or received
(#1901)

Support the latest phone number formats via libphonenumber update
(#1899)

Intl-friendly sort order for contact lists (#1900)

Show window if hidden to tray when second instance attempts to start
(#1897)

Make the window minimum width a little smaller - thanks @emptyflask
(#1863)

Fix issue where duplicate emoji were listed in the emoji panel (#1893)

The default button is now 'later', not 'restart' in the
'update available' dialog (#1894)

Dev:
  - Add .deb specific dependencies - thanks @veggiedefender (#1858)
@Dyras
Copy link

Dyras commented Dec 16, 2017

@scottnonnenberg I'm on beta 6 and I still see some duplicates. Did you miss some? Or am I just stupid?

@scottnonnenberg
Copy link
Contributor Author

Hit me with specifics. I'm relying on the metadata to tell me which emoji should be dropped, and and I did see a lot of triplets turn into doubles.

@scottnonnenberg
Copy link
Contributor Author

Just did a quick check, and it looks like there are just a couple duplicates left:

:face_palm: and :man-facepalming:

:shrug: and :woman-shrugging:

Unless there are more than that, I think we can leave it as-is. There's also the possibility of some sort of specific issue on your system?

@Dyras
Copy link

Dyras commented Dec 16, 2017

@scottnonnenberg I think it's just those two. I was confused by the similar ones like :man-frowning: and :man-pouting: since they are pretty much identical.

I think it's fine the way it is now, but I wouldn't complain if you removed the dupes next time you update the emojis. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants