Add support for Emoji 5 #1797
Merged
Add support for Emoji 5 #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bonus! Fixed dark theme issues in #1763.
|
|
Just to make sure I have this straight: Emoji 5 comes in Think we're good to go on this as soon as we get those merge conflicts resolved. |
|
These two version numbers are not connected. Emoji 5 is the latest Unicode release from May 2017 (Unicode 10 / Emoji 5). |
Update to latest emoji-datasource and emoji-js and switch to an up-to-date fork of emoji-panel. // FREEBIE
Fixes #1763 // FREEBIE
scottnonnenberg
force-pushed
the
emoji5
branch
from
18efee8 to
6ba7af2
Compare
This was referenced Dec 2, 2017
scottnonnenberg
added a commit
that referenced
this pull request
Dec 5, 2017
Add proxy support based on environment variables (#1855) Fix issue where window would not show new message alerts on some Linux systesm - thanks @cornerman (#1820) Add a tray icon to the application behind command-line argument - thanks @m-pilia (#1676) Emoji: - Fix issue where clicks in emoji panel wouldn't do anything (#1849) - Add support for Emoji 5 - thanks @liliakai (#1797) - Eliminate unused emoji images from production package (#1849) Deployment: - aptly.sh: support for current and previous ubuntu versions (#1856) - deployment: update electron-publisher-s3 to match builder update (17f0bb4) Dev: - Update development branch to include everything up to v1.0.40 (f013eed and 3ac29a4) - Update readme.md to use signal.org URLs - thanks @scienmind (#1814)
scottnonnenberg
added a commit
that referenced
this pull request
Dec 20, 2017
Note: This release is the same thing as https://github.com/WhisperSystems/Signal-Desktop/releases/tag/v1.1.0-beta.6 Listed below are the changes from the previous production release: https://github.com/WhisperSystems/Signal-Desktop/releases/tag/v1.0.41 Update to electron 1.7.9 (#1736) Support the latest phone number formats via libphonenumber update (#1899) Reduce download size by ~25MB over the previous production build (#1869) Emoji - thanks @liliakai: - Emoji picker (#1608) - Add support for Emoji 5 (#1797) Notifications: - Windows 7: Use an alternate mechanism for notifications (#1812) - Prevent drawAttention() when notifications are turned off - thanks @canerelci! (#1612) Linux: - Support for current (artful) and previous (xenial) ubuntu versions (#1856) - Fix missing application icon on some Linux distributions (#1735) - Fix issue where window would not show new message alerts on some Linux systems - thanks @cornerman (#1820) - Add .deb specific dependencies - thanks @veggiedefender (#1858) The default button is now 'later', not 'restart' in the 'update available' dialog (#1894) Make the window minimum width a little smaller - thanks @emptyflask (#1863) Intl-friendly sort order for contact lists (#1900) Fix issue where update would restore deleted windows shortcut (#1804) Fix issue where .tif file attachments could not be sent or received (#1901) (in testing) Add a tray icon to the application behind command-line argument - thanks @m-pilia (#1676) --use-tray-icon enables the tray icon --start-in-tray enables the tray icon and the application starts minimized in the tray bar (in testing) Support pass-through proxies with HTTPS_PROXY environment variable (#1878) Dev: - Display of environment and app instance in title bar/about window (#1606) - Support for beta releases installed beside production versions (#1606) - Fix json parsing exceptions obscuring server errors (#1605) - Be resilient to thrown non-errors in import process (#1737)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to latest emoji-datasource and emoji-js and switch to an up-to-date fork of emoji-panel. I wish I could show you all the new emojis that this adds, like
:grinning_face_with_star_eyes:,:shocked_face_with_exploding_head:,:serious_face_with_symbols_covering_mouth:, and:face_with_open_mouth_vomiting:but github doesn't even support them yet!I targeted this PR at the
developmentbranch because it affects the emoji panel which is still only available in beta. However, if the panel is ready for release, I'd be happy to rebase and retarget this PR so that it adds the panel and the emoji 5 upgrade to master.One small concern for developers is that I've used a git repo url as a dependency version identifier in package.json. I've observed when running
yarn installwith a repo url as a package source, yarn tends to cache the repo state too aggressively. If the target commit-hash changes, the cached copy of the repo must be rm'd before running yarn install again, or the install will fail with something likeFailed: git archive $commitish. To alleviate this, we can switch back to OG emoji-panel whenever they merge the PR I filed against them, but if they do not I can also publish my fork under a different npm module name.