-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS: Signal Desktop enables Secure Input (conflict with Logitech) #4067
Comments
So you were able to run I just did it locally and did not see Signal Desktop listed. |
That's correct. Quitting the Signal app entirely fixed the issue as well. |
Bitwarden is having the same issue. They indicate it might be related to an electron update that happened late last year. This definitely might be the case here. I've combed this source code and can't find anything explicitly enabling secure input. I've found that when bitwarden locks it autofocuses on the password textbox to unlock it, thus enabling Secure Input. If I click out of the password box, Secure Input is disabled and everything starts working again. Next time it happens I'm going to check what the Signal app has in focus. |
Same problem with Espanso. Espanso stops working when Signal is running. **WARNING: An application is currently using SecureInput and might prevent espanso from working correctly. APP: Signal Please close it or disable SecureInput for that application (most apps that use it have a |
I am experiencing the same issues with Signal affecting Logitech mouse and espanso. (Version 5.2.0). |
I'm seeing this today on version 5.2.0 |
In the Signal app it seems that secure Input is only active when an input box, e.g. the Send a message or Search input boxes, has keyboard focus. Therefore a "workaround" would be clicking on anything in the Signal app that causes the input box to lose focus, such as a message. This deactivates secure input and allows espanso and the mouse to work again correctly. |
I just updated the Signal app today and having the same issue with ShareMouse. Switching to other applications doesn't disable the "Secure Input" warning. It looks like @hungryphilomath workaround is working. Hopefully, a fix will be released soon :) Signal app: 5.2.0 |
Just started having this issue since updating to 5.2.0 (my issue is with Keyboard Maestro, certain features don't work when Signal is open. When you open Keyboard Maestro it is nice enough to identify the app causing the issue (Signal). If I quit Signal the issue goes away. Moving focus away from the input box doesn't fix the issue for me however, my issue is a little bit different than the other comments (I have opt + W set to "Simulate keystroke: cmd + W"). Maestro prompt: This will stop typed string triggers from working, as well as stop Keyboard Maestro from sensing your keystrokes while setting hot keys. You will need to find the offending application (probably Signal) and quit it." Signal app: 5.2.0 |
Since update to v5.2.0 this is also happening to me. |
I can confirm I have this issue as well, took me a couple hours to track down issue specifically to Signal, but was able to replicate it well over 10 times so I know 100% it's from Signal Desktop. Signal v5.2.0 Breaks any kind of text expander application (Rocket Typist, Text Expander), as well as all Logitech options handling, mouse looses scroll, and side buttons and side scroll wheel. Keyboard loses all non-standard functionality (volume, screenshots, etc). If the application is open it doesn't break anything, the minute I select a chat or perform any action in the window, breaks everything. Kill application, everything works normal again. Being a full time developer this is killing me as my mouse and keyboard is my most used tool. |
@scottnonnenberg @scottnonnenberg-signal
➜ ioreg -l -d 1 -w 0 | grep SecureInput
"IOConsoleUsers" = ({"kCGSSessionOnConsoleKey"=Yes,"kSCSecuritySessionID"=XXX,"kCGSSessionSecureInputPID"=23558,"kCGSSessionGroupIDKey"=XXX,"kCGSSessionIDKey"=XXX,"kCGSessionLoginDoneKey"=Yes,"kCGSSessionSystemSafeBoot"=No,"kCGSSessionUserNameKey"="XXX","kCGSessionLongUserNameKey"="XXX","kCGSSessionAuditIDKey"=XXX,"kCGSSessionLoginwindowSafeLogin"=No,"kCGSSessionUserIDKey"=501}) ➜ lsof -p 23558
COMMAND PID USER FD TYPE DEVICE SIZE/OFF NODE NAME
Signal 23558 myles cwd DIR 1,5 736 2 /
Signal 23558 myles txt REG 1,5 390000 83718775 /Applications/Signal.app/Contents/MacOS/Signal Happens 100% of the time. Related #5279 |
Oh gosh, this is awful. Sorry it causes issues for y'all! This in our list and we'll look into it. |
Came here to write a bug as it breaks Synergy. I definitely started in v5.2.0 and I can roll back-and-forward to see the behavior. Looking at the commits could it have been this? If so can it be quickly rolled back? |
Same issue with Synergy (Signal running on my Synergy server machine). For me there is a work-around: click the Signal window to blur/unfocus the composition text input before moving your mouse to another screen. The on-blur seems to disable SecureInput correctly. The issue for me was when I click another app window while the Signal composition text input is still focused. It appears to blur visually, but fails to disable SecureInput. Perhaps the fix is to disable SecureInput in the "on Window blur" event. |
Have this problem with Signal since the update to 5.2.0 Can reproduce 100% of the time. Open the app, no problem |
Was working fine with Synergy before 5.2.0 so not sure the issue is the same, but surely related. I found the following script from https://github.com/symless/synergy-core/issues/5203 which helped diagnose when SecureEventInput is being turned on and off.
EDIT: Confirmed that 5.2.1 does address this issue with Synergy |
For what it's worth this is also breaking SKHD. And I'm a little surprised that this ticket has been around for so long. I've been using Signal and SKHD side by side for months now and haven't had any problems until the app updated yesterday. Based on the history of comments on this ticket it seems like I'm not the only one, so I'd hazard 5.2.0 made things worse somehow. |
Same problem here with Signal 5.2.0. As soon as I open the app on my MacBook Pro it turns on Secure Input which disables TextExpander (which I simply cannot live without). So until it's fixed I'm simply not going to be able to run Signal desktop. And I love Signal desktop!! |
HORRAY HORRAY guys update to 5.2.1 and it fixes this issue!! @indutny-signal or whoever made this happen, thank you thank you!! Moxie would be proud (if not already) https://updates.signal.org/desktop/signal-desktop-mac-5.2.1.dmg |
I updated to v5.2.1 and it seems to have fixed the issue 🥳 Thanks a lot guys! |
I confirm the issue is resolved with v5.2.1. Woohoo! 😺 |
This was a team effort. Glad to see it works for you now! |
@indutny-signal Kudos to you guys! |
Thanks for fixing this issue so quickly! I noticed it today as well. But I do want to note that I'm not sure the original bug I opened this for has been fixed. I've been experiencing this intermittently well before fc12d02 was made. |
This is truly amazing turnaround! I'm in awe. Seriously. |
I just upgraded to 5.2.1 and it did the trick too. Super thanks—I can't live without Signal and I can't live with TextExpander. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been closed due to inactivity. |
Bug Description
At some point, Signal enables "Secure Input" on OS X but doesn't disable it when the app is in the background. This causes Logitech Options to be unable to monitor input properly which results in my Logitech mouse not functioning properly.
Steps to Reproduce
Unfortunately, I haven't been able to reproduce the issue reliably. This leads me to believe there's either a race condition or an edge case that isn't handled properly. I used the steps described in this document from Logitech to figure out Signal was the culprit. The FAQ item is located near the bottom and titled "Logitech Options issues when Secure Input is enabled". I would have used a deep link if it was available.
Actual Result:
Secure Input stays enabled regardless of Signal being in focus or in the background.
Expected Result:
When Signal is in the background or a text entry field isn't focused, Secure Input should be disabled.
Screenshots
Platform Info
Signal Version: v1.32.1
Operating System: macOS 10.15.3 (19D76)
The text was updated successfully, but these errors were encountered: