-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emoji Drawer/Menu/Panel #194
Comments
Any word on this? It's been over a year. Emoji's are really helpful for avoiding ambiguity and miscommunication and are pretty standard in text communication these days... Wouldn't something like this be simple enough for now? As for button placement, a smiley button just like the Android client would be perfect... |
Can be interesting? |
I've noticed if you are viewing an emoji in Signal Desktop, you can highlight and copy/paste it into the message and it usually works fine. No idea why we still can't use emojis like nearly every other message platform. As a workaround, you can create a message with all your most used emoji's and copy/paste into new messages as needed. |
@ThoughtPhotography using emoji is entirely possible, as you yourself note - entering them is where Signal-Desktop could use an emoji drawer. Copy&pasting them is possible, as is referring to them by name ( |
Yeah, that's what I mean. Basically all an "emoji drawer" would need to be is the equivalent of a few standard texts containing the categories of emojis. Stick a button beside the attachment one, emojis pop up, click on the one you want, and it's automatically copied/pasted into your message. Ideal? No. Simple, and functional? Yes. :) We'll soon be coming up to a year with Signal Desktop, and this still feels like a noticeable omission when it comes to regular daily usage... |
Hi I've tried to add an emoji panel. It is based on jquery-emojiarea project https://github.com/diy/jquery-emojiarea Essentially, when you click on an emoji icon, this is translated into the colon format. Simple and clean. I had to do some hacks to make it working with Signal. Now it uses a completely list of emoji files because I couldn't find an easy way to categorize the current ones. All the new emoji and the js/css are in the folder components/jquery-emojiarea. This is the result This is the link for the branch https://github.com/aigna/Signal-Desktop/tree/emoji-panel UPDATE: sorry I forgot to say that it passed all the tests. |
Fantastic work! :) I'm not sure how the process works, but I assume just wait a while and it will be in a future build? |
Is there a reason a pull request was never made or this wasn't taken a look at? I know it's only been a few months (which isn't long in Signal Desktop time) but just curious. Would a pull request get this integrated faster? |
Just weighing in to say that I'd also greatly appreciate this feature being implemented soon. |
@datacorruption Please don't bump or +1 issues. You can use github's emoji reactions to express your support. See Contributing for more info. |
@ping133 Any reason why you didn't make a pull request from that branch? I can imagine maintainers not keeping track of comments on all issues, whereas they'd get a notification from a new pull request... |
@ping133 are you still working on it? Or shall someone else create a PR for this? Edit: I started a rebase here https://github.com/lichtamberg/Signal-Desktop/tree/emoji_picker, but didn't finish it and probably messed up history as well. Since I didn't develop anything for signal until now, I have to setup first my development environment, run som tests and cleanup the history before I create a PR - just to let you know. |
I'm currently working on this in the |
@liliakai nice, great. I hope you saw the PR which I started - and the reasons why it was declined (github icons). Edit: Lol - oh - you declined it ^^ ok :D |
We support text-entry :emoji: but we should also have a button that pops up a nice shiny menu/drawer. We'll probably need to move to a sprite-based emoji implementation to make this work.
Re: button placement, we can probably sacrifice the send button, ala Hangouts.
The text was updated successfully, but these errors were encountered: