Updated Transport UI to be more "Hangouts-Like" #2289
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mcginty: I believe this is your domain? |
|
I'm thinking perhaps I need to add a bit of green through the loop of the lock on the SMS icons? |
|
Isn't |
|
@agrajaghh it's like that for me with current master too, I haven't changed the behaviour as to what transports are enabled. |
|
I have got contacts where all three are enabled however... |
|
okay :) |
Transport selection functionality has now moved to a button on the left of the text box and changes when pressed. // FREEBIE
// FREEBIE
s0
force-pushed
the
transport-select-ui-updates
branch
from
f44b7ca to
f5dd0bb
Compare
|
Rebased ontop of current head, and replaced TS transport icon with latest logo. |
|
Thanks, but we're thinking of adding a tool tip for our current send button selector instead of breaking things out into a separate component. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following comments on #2285 #845 #1724.
UI is now suitable to allow for persistent transport selection.
Screenshots:
SMS Only Contact
Other Contacts
