-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ict 4483 - add job attach to wait for job execution #123
Conversation
davixcky
commented
Jun 5, 2024
•
edited
Loading
edited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good to me. But the it seemed connected / attached for a while after the job was completed before disconnecting with the below message:
./signadot --config ~/.signadot/staging.yaml job submit -f control-backend-e2e.yaml --attach
Job control-backend-e2e-ptc0dxq queued on Job Runner Group: control-e2e
Dashboard page: https://app.signadot.com/testing/jobs/control-backend-e2e-ptc0dxq
Waiting for job execution
Cloning signadot repo
Running backend e2e tests
newman
Latest-Operator-Version
→ latest-operator-version (member user)
GET https://api.staging.signadot.com/api/v1/vars/latest-operator-version
200 OK ★ 521ms time ★ 1.13kB↑ 306B↓ size ★ 9↑ 7↓ headers ★ 0 cookies
┌ ↓ application/json ★ text ★ json ★ utf8 ★ 94B
...
logs
...
&{%!s(*models.JobsCanceledState=<nil>) %!s(*models.JobsCompletedState=&{0 }) %!s(*models.JobsQueuedState=<nil>) %!s(*models.JobsRunningState=<nil>)}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw the connection persist beyond job completion with the logs command too.
./signadot --config ~/.signadot/staging.yaml logs --job control-backend-e2e-wmmx22i
Even in this case, the connection stayed intact for a while (maybe 20/30 seconds) after the job completed.
Since this seems to be external to the scope of this PR, I will go ahead and approve it.
This could be directly or indirectly related to https://github.com/signadot/signadot/issues/4484 as well. But let's create a separate ticket for the cli so that it doesn't get forgotten.
Dismissing review based on some comments by Daniel.
I think the For example, imagine the case when we restart the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM