Support ict (jobs and jobrunnergroup) #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davixcky
requested review from
daniel-de-vera,
scott-cotton and
foxish
and removed request for
daniel-de-vera
foxish
reviewed
May 24, 2024
foxish
reviewed
May 24, 2024
foxish
reviewed
May 24, 2024
jmsktm
previously requested changes
May 28, 2024
add logs command add sse client lib
jmsktm
dismissed
their stale review
Canceling blocking review since the authorization change with hard-coded bearer token has been removed.
jmsktm
reviewed
May 28, 2024
foxish
reviewed
May 30, 2024
There was a problem hiding this comment.
Ran through some of the test cases and it looks good to start. Only pending comment I have is that we should have job get output also reflect which jrg it's intending to run on. That's currently not visible. Rest of the behavior LGTM - @jmsktm - please approve once the code passes muster since you've been reviewing it more closely.
foxish
reviewed
May 30, 2024
foxish
reviewed
May 30, 2024
jmsktm
reviewed
May 30, 2024
internal/command/jobs/printers.go
Outdated
| fmt.Fprintf(tw, "Status:\t%s\n", job.Status.Phase) | ||
| fmt.Fprintf(tw, "Environment:\t%s\n", getJobEnvironment(job)) | ||
| fmt.Fprintf(tw, "Created At:\t%s\n", getCreatedAt(job)) | ||
| fmt.Fprintf(tw, "Started At:\t%s\n", createdAt) |
There was a problem hiding this comment.
Should display value corresponding to start time.
jmsktm
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support to full JobRunnerGroup and work for Jobs still going (pending to see logs, download artifacts, cancel job)