fixes to unknown field handling #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unknown field handling prevents overwriting unknown fields with their default value, as can be problematic for example with TTL. - add it to resource plugin - make it apply only to spec
Comment on lines
22
to
36
| var ( | ||
| name string | ||
| ok bool | ||
| spec any | ||
| ) | ||
| switch x := un.(type) { | ||
| case map[string]any: | ||
| name, ok = x["name"].(string) | ||
| spec = x["spec"] | ||
| default: | ||
| } | ||
| if !ok { | ||
| return nil, errors.New("missing name or spec fields") | ||
| } | ||
| d, err := json.Marshal(spec) |
There was a problem hiding this comment.
Can we place this logic into a function? (and call it from resourceplugin, routegroup and sandbox)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unknown field handling prevents overwriting unknown fields with their default value, as can be problematic for example with TTL.