Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap PNG for SVG logo now that GitHub renders #306

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Conversation

Teque5
Copy link
Collaborator

@Teque5 Teque5 commented Jan 13, 2024

Now that GitHub will render an SVG in markdown files, replace the low resolution PNG with a nice vector image. Unfortunate svgz is not supported, since that one is only 11KB.

Best we can do for now per request in #297 by @777arc.

@Teque5 Teque5 requested a review from 777arc January 13, 2024 17:17
@777arc
Copy link
Member

777arc commented Jan 14, 2024

Is it OK if we leave the png? Both in case anyone is already referencing it, and just because it's convenient for folks who need a png

@Teque5
Copy link
Collaborator Author

Teque5 commented Jan 15, 2024

Now keeping PNG and SVG; leaving SEO unoptimization.

@Teque5
Copy link
Collaborator Author

Teque5 commented Jan 15, 2024

I recall that the reason we left that long URL in the README.md was so that when PyPi uses it as the doc it still renders the image.

@777arc 777arc self-requested a review January 15, 2024 01:36
@Teque5 Teque5 merged commit a6eb9d7 into sigmf-v1.x Jan 15, 2024
@Teque5 Teque5 deleted the bugfix/logo branch April 12, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants